luleg - Technical Training - Creation of the Real Estate Module#1176
luleg - Technical Training - Creation of the Real Estate Module#1176
Conversation
|
|
AlessandroLupo
left a comment
AlessandroLupo
left a comment
There was a problem hiding this comment.
Nice work! 👍
Ideally, we should have a single commit per tutorial chapter. But I see that you introduced some code in advance (for example, EstateTagCategory is introduced in chapter 7, right?). Is there a specific reason for this? As a git exercise, you could try to move some of this content to the right commit when you reach the correct chapter.
It is very good that you fixed the styling error. You could try to do it in the already existing commits instead of adding a new one.
Depending on your confidence with git, this may be boring or may be very interesting. Feel free to ask for help if you need :)
|
Thank you for the feedbacks! I kinda just go and find what I need for what I want to do and do it ^^' Well, about moving parts of the code... it would probably be pretty annoying, I know a bit of git but in no way in hell do I already know how to do that in particular (moving code around commits) (especially now that it's pushed and assuming I don't force push, which I would love not to do). |
|
Good job 👍 I see your runbot is red, please try to fix the problems and make it green. It's just a styling error and a problem about an invisible element, feel free to ask for help :) |
3 participants
Here is my progress on the Technical training
Don't hesitate to give me feedbacks about what I could improve.